Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(skin): IOS-9684 update design tokens from mistica-design branch: production #331

Merged
merged 5 commits into from
Jan 25, 2024
Merged

feat(skin): IOS-9684 update design tokens from mistica-design branch: production #331

merged 5 commits into from
Jan 25, 2024

Conversation

tuentisre
Copy link
Collaborator

@tuentisre tuentisre commented Jan 19, 2024 •
edited by amegias
Loading

🎟️ Jira ticket

https://jira.tid.es/browse/IOS-9684

🥅 What's the goal?

Update tokens related to new-vivo brand for 24.1.

🚧 How do we do it?

  1. Get the changes from mistica-design repo using our tool => https://github.com/Telefonica/mistica-ios/actions/runs/7582804433
    • It generated this PR
  2. Tests failed (obviously) => https://github.com/Telefonica/mistica-ios/actions/runs/7582809783
    • Tests Failed: 68 failed, 0 skipped, 458 total
  3. Execute the screenshot generation action => https://github.com/Telefonica/mistica-ios/actions/runs/7583943484
    • 68 png's updated

🧪 How can I verify this?

Please @yceballost could you check that the changes are expected? the screenshots look good to me
I can generate a Mistica Catalog and/or a Novum app with this update.
✅ The affected screenshots are related to new-vivo [only]

@tuentisre tuentisre requested review from a team, pbartolome and dhidalgofadrique and removed request for a team January 19, 2024 10:53
@amegias amegias marked this pull request as draft January 19, 2024 10:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 19, 2024 •
edited
Loading

Screenshot tests report

❌ DeterminateStepperTests / testDeterminateStepperDefaultState()
❌ IndeterminateStepperTests / testIndeterminateStepperDefaultState()

@amegias amegias marked this pull request as ready for review January 19, 2024 13:58
@amegias amegias changed the title feat(skin): update design tokens from mistica-design branch: production feat(skin): IOS-9684 update design tokens from mistica-design branch: production Jan 19, 2024
@amegias
Copy link
Contributor

amegias commented Jan 19, 2024

@yceballost should we do https://github.com/Telefonica/mistica-ios/pull/327/files#diff-fb8824eed7bb698d3e5561f72e0dadd757aa09e1839758a9a6cf57a22bf0f101R77 ?

@yceballost
Copy link
Contributor

@yceballost should we do #327 (files) ?

yes please, use barTrack token in progressBar / Stepper / Slider (I think slider is not included in mística ios)

yceballost
yceballost reviewed Jan 19, 2024
View reviewed changes
...hots__/IndeterminateStepperTests/testIndeterminateStepperDefaultState.with-vivoNew-style.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is wrong, using barTrack should be solved

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you check it again please?

@amegias
Copy link
Contributor

amegias commented Jan 23, 2024

@yceballost should we do #327 (files) ?

yes please, use barTrack token in progressBar / Stepper / Slider (I think slider is not included in mística ios)

Done, could you check it again pls?

@amegias
Copy link
Contributor

amegias commented Jan 25, 2024

Screenshots result are not updated (since the actions cannot be triggered from a bot action like comiting screenshots). Anyway, CI is passing https://github.com/Telefonica/mistica-ios/actions/runs/7624085949

@amegias amegias merged commit 7ba2e09 into main Jan 25, 2024
1 check passed
@amegias amegias deleted the import-design-tokens branch January 25, 2024 15:15
tuentisre pushed a commit that referenced this pull request Jan 25, 2024
@semantic-release-bot
chore(release): 29.1.0 [skip ci]
e653470 
# [29.1.0](v29.0.0...v29.1.0) (2024-01-25)

### Features

* **skin:** IOS-9684 update design tokens from mistica-design branch: production ([#331](#331)) ([7ba2e09](7ba2e09))
@tuentisre
Copy link
Collaborator Author

🎉 This PR is included in version 29.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amegias amegias amegias left review comments

@pbartolome pbartolome pbartolome approved these changes

@yceballost yceballost yceballost approved these changes

@alejandroruizponce alejandroruizponce alejandroruizponce approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tuentisre @amegias @yceballost @pbartolome @alejandroruizponce