-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(skin): IOS-9684 update design tokens from mistica-design branch: production #331
Conversation
yes please, use barTrack token in progressBar / Stepper / Slider (I think slider is not included in mΓstica ios) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is wrong, using barTrack should be solved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you check it again please?
Done, could you check it again pls? |
Screenshots result are not updated (since the actions cannot be triggered from a bot action like comiting screenshots). Anyway, CI is passing https://github.com/Telefonica/mistica-ios/actions/runs/7624085949 |
π This PR is included in version 29.1.0 π The release is available on GitHub release Your semantic-release bot π¦π |
ποΈ Jira ticket
https://jira.tid.es/browse/IOS-9684
π₯ What's the goal?
Update tokens related to new-vivo brand for 24.1.
π§ How do we do it?
π§ͺ How can I verify this?
Please @yceballost could you check that the changes are expected? the screenshots look good to me
I can generate a Mistica Catalog and/or a Novum app with this update.
β The affected screenshots are related to new-vivo [only]