LATCH-1000: fix Button disabled state #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaranaz
requested review from
a team,
idenjoe and
WanaldinoTelefonica
and removed request for
a team
jaranaz
force-pushed
the
LATCH-1000-fix-button-disabled
branch
from
29dc4f2
to
1c53613
Compare
idenjoe
reviewed
Oct 13, 2023
| @@ -43,8 +43,8 @@ public extension ButtonStyle where Self == MisticaButtonStyle { | |||
| ), | |||
| .disabled: MisticaButton.StateStyle( | |||
| textColor: .textButtonPrimary, | |||
| backgroundColor: .buttonPrimaryBackground, | |||
| borderColor: .buttonPrimaryBackground | |||
| backgroundColor: .buttonPrimaryBackground.opacity(0.5), | |||
There was a problem hiding this comment.
IMHO I would use constants for these opacities since they are repeated in many places.
idenjoe
approved these changes
Oct 13, 2023
jaranaz
force-pushed
the
LATCH-1000-fix-button-disabled
branch
from
700bd4c
to
99ea66f
Compare
jaranaz
force-pushed
the
LATCH-1000-fix-button-disabled
branch
from
99ea66f
to
b92c215
Compare
tuentisre
pushed a commit
that referenced
this pull request
Oct 16, 2023
# [26.2.0](v26.1.0...v26.2.0) (2023-10-16) ### Bug Fixes * **Button:** change colors for disabled style ([#308](#308)) ([e829160](e829160)) * **Button:** change colors for disabled style ([#310](#310)) ([fb108a1](fb108a1)) * **Button:** Change cornerCurve from continuous to circular ([#307](#307)) ([26a73b3](26a73b3)) * **Snackbar:** change color for action button ([#304](#304)) ([7054e3d](7054e3d)) * **Tag:** change foreground and background colors according to specs ([#309](#309)) ([6a9f441](6a9f441)) ### Features * **Button:** Added accesibility to right image (chevron) ([05d77d9](05d77d9))
|
🎉 This PR is included in version 26.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Jira ticket
https://jira.tid.es/browse/LATCH-1000
🥅 What's the goal?
The
Buttoncomponent for SwiftUI is using wrong colors for its disabled state.This PR completes the already merged PR #308, where some states were missed.
🏑 AppCenter build