LATCH-987 Fix Snackbar button color #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaranaz
requested review from
a team,
pbartolome,
WanaldinoTelefonica and
yceballost
and removed request for
a team
|
Screenshot tests report ✔️ All passing |
jaranaz
force-pushed
the
LATCH-987-fix-snackbar-button-color
branch
from
d3c015f
to
35ce5b7
Compare
pbartolome
approved these changes
Sep 22, 2023
yceballost
approved these changes
Sep 23, 2023
| static func misticaSnackbar( | ||
| small: Bool = false, | ||
| bleedingAlignment: ButtonBleedingAlignment = .none, | ||
| withChevron: Bool = false |
There was a problem hiding this comment.
IMO this should not be avalable as chevron is only available on link style
jaranaz
force-pushed
the
LATCH-987-fix-snackbar-button-color
branch
from
078b542
to
cc17c63
Compare
tuentisre
pushed a commit
that referenced
this pull request
Oct 16, 2023
# [26.2.0](v26.1.0...v26.2.0) (2023-10-16) ### Bug Fixes * **Button:** change colors for disabled style ([#308](#308)) ([e829160](e829160)) * **Button:** change colors for disabled style ([#310](#310)) ([fb108a1](fb108a1)) * **Button:** Change cornerCurve from continuous to circular ([#307](#307)) ([26a73b3](26a73b3)) * **Snackbar:** change color for action button ([#304](#304)) ([7054e3d](7054e3d)) * **Tag:** change foreground and background colors according to specs ([#309](#309)) ([6a9f441](6a9f441)) ### Features * **Button:** Added accesibility to right image (chevron) ([05d77d9](05d77d9))
|
🎉 This PR is included in version 26.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Jira ticket
https://jira.tid.es/browse/LATCH-987
🥅 What's the goal?
Component
Snackbaris using tokentextLinkfor its action button, instead of the right tokentextLinkSnackbar🚧 How do we do it?
Create new
MisticaButtonStyletype called.misticaSnackbarwith the right color token.🧪 How can I verify this?