Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(InputField): Avoid TextField auto expands horizontally #289

Merged
merged 2 commits into from
Jul 19, 2023
Merged

fix(InputField): Avoid TextField auto expands horizontally #289

merged 2 commits into from
Jul 19, 2023

Conversation

WanaldinoTelefonica
Copy link
Contributor

🎟️ Jira ticket

IOS-8333

🥅 What's the goal?

  • Avoid TextField auto expands horizontally
  • Limit placeholder to one line

🚧 How do we do it?

  • Set that the UITextField wrapped in the pomponent has low priority to resist being smaller, so when the text written is longer than the width it doen't expand.
  • Set placeholder to one line, so if you set a long text the component do not deforms.

🧪 How can I verify this?

testLongAssistiveText 1
testLongPlaceholder 1
testLongText 1

🏑 AppCenter build

@WanaldinoTelefonica WanaldinoTelefonica requested a review from a team July 13, 2023 07:31
@WanaldinoTelefonica WanaldinoTelefonica self-assigned this Jul 13, 2023
@WanaldinoTelefonica WanaldinoTelefonica requested review from idenjoe and alexanegon and removed request for a team July 13, 2023 07:31
alexanegon
alexanegon approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@alexanegon alexanegon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job & congratulations on your first PR!

idenjoe
idenjoe approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@idenjoe idenjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@WanaldinoTelefonica WanaldinoTelefonica merged commit c321d88 into main Jul 19, 2023
@WanaldinoTelefonica WanaldinoTelefonica deleted the IOS-8333_Avoid_TextField_autoexpands_horizontally branch July 19, 2023 08:18
tuentisre pushed a commit that referenced this pull request Jul 19, 2023
@semantic-release-bot
chore(release): 25.3.1 [skip ci]
36351f4 
## [25.3.1](v25.3.0...v25.3.1) (2023-07-19)

### Bug Fixes

* **Bottom Sheet:** Fix component to expand horizontally ([#290](#290)) ([266c5d8](266c5d8))
* **InputField:** Avoid TextField auto expands horizontally ([#289](#289)) ([c321d88](c321d88))
@tuentisre
Copy link
Collaborator

🎉 This PR is included in version 25.3.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idenjoe idenjoe idenjoe approved these changes

@alexanegon alexanegon alexanegon approved these changes

Assignees

@WanaldinoTelefonica WanaldinoTelefonica

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WanaldinoTelefonica @tuentisre @idenjoe @alexanegon