fix(Bottom Sheet): Fix component to expand horizontally #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WanaldinoTelefonica
requested review from
Gomay88 and
alejandroruizponce
and removed request for
a team
alexanegon
approved these changes
Jul 19, 2023
| @@ -84,13 +82,12 @@ private extension InformativeRow { | |||
| bottomContent.isHidden = true | |||
| } | |||
|
|
|||
| dummyView.amount = item.icon.size.width | |||
| bottomContent.layoutMargins.left = item.icon.size.width + 8 | |||
There was a problem hiding this comment.
IMHO Magic number "8" must be in a descriptive constant because you are using it here and in the frontStackView WDYT?
There was a problem hiding this comment.
Sure, I've changed it 😄
Gomay88
approved these changes
Jul 19, 2023
|
🎉 This PR is included in version 25.3.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Jira ticket
IOS-9113
🥅 What's the goal?
🚧 How do we do it?
Info: The dot is centered on a single line label with the same specs than the visible label, but is in a deeper layer stackView.
🧪 How can I verify this?