Skip to content
analyze and review code

Merge tag 'steve-3.6.0' into develop #4

Sign in to view logs

Merge tag 'steve-3.6.0' into develop

Merge tag 'steve-3.6.0' into develop #4

Triggered via push June 10, 2024 10:32
@HejkiHejki
pushed c98a3c4
develop
Status Failure
Total duration 41s
Artifacts 1

review.yml

on: push
license-check
31s
license-check
pmd
12s
pmd
checkstyle
15s
checkstyle
Fit to window
Zoom out
Zoom in

Annotations

1 error and 15 warnings
license-check
Process completed with exit code 1.
pmd
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-java@v3, pmd/pmd-github-action@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Do not hard code the IP address : src/main/java/de/rwth/idsg/steve/JettyServer.java#L226
Application with hard-coded IP addresses can become impossible to deploy in some cases. Externalizing IP adresses is preferable. AvoidUsingHardCodedIP (Priority: 3, Ruleset: Best Practices) https://pmd.github.io/pmd-6.49.0/pmd_rules_java_bestpractices.html#avoidusinghardcodedip
Avoid empty catch blocks: src/main/java/de/rwth/idsg/steve/JettyServer.java#L262
Empty Catch Block finds instances where an exception is caught, but nothing is done. In most circumstances, this swallows an exception which should either be acted on or reported. EmptyCatchBlock (Priority: 3, Ruleset: Error Prone) https://pmd.github.io/pmd-6.49.0/pmd_rules_java_errorprone.html#emptycatchblock
Avoid empty catch blocks: src/main/java/de/rwth/idsg/steve/JettyServer.java#L270
Empty Catch Block finds instances where an exception is caught, but nothing is done. In most circumstances, this swallows an exception which should either be acted on or reported. EmptyCatchBlock (Priority: 3, Ruleset: Error Prone) https://pmd.github.io/pmd-6.49.0/pmd_rules_java_errorprone.html#emptycatchblock
Do not hard code the IP address : src/main/java/de/rwth/idsg/steve/JettyServer.java#L276
Application with hard-coded IP addresses can become impossible to deploy in some cases. Externalizing IP adresses is preferable. AvoidUsingHardCodedIP (Priority: 3, Ruleset: Best Practices) https://pmd.github.io/pmd-6.49.0/pmd_rules_java_bestpractices.html#avoidusinghardcodedip
Avoid empty catch blocks: src/main/java/de/rwth/idsg/steve/JettyServer.java#L278
Empty Catch Block finds instances where an exception is caught, but nothing is done. In most circumstances, this swallows an exception which should either be acted on or reported. EmptyCatchBlock (Priority: 3, Ruleset: Error Prone) https://pmd.github.io/pmd-6.49.0/pmd_rules_java_errorprone.html#emptycatchblock
Useless parentheses.: src/main/java/de/rwth/idsg/steve/JettyServer.java#L288
Useless parentheses should be removed. UselessParentheses (Priority: 4, Ruleset: Code Style) https://pmd.github.io/pmd-6.49.0/pmd_rules_java_codestyle.html#uselessparentheses
Avoid empty catch blocks: src/main/java/de/rwth/idsg/steve/JettyServer.java#L294
Empty Catch Block finds instances where an exception is caught, but nothing is done. In most circumstances, this swallows an exception which should either be acted on or reported. EmptyCatchBlock (Priority: 3, Ruleset: Error Prone) https://pmd.github.io/pmd-6.49.0/pmd_rules_java_errorprone.html#emptycatchblock
Do not hard code the IP address : src/main/java/de/rwth/idsg/steve/JettyServer.java#L298
Application with hard-coded IP addresses can become impossible to deploy in some cases. Externalizing IP adresses is preferable. AvoidUsingHardCodedIP (Priority: 3, Ruleset: Best Practices) https://pmd.github.io/pmd-6.49.0/pmd_rules_java_bestpractices.html#avoidusinghardcodedip
Unused import 'com.fasterxml.jackson.datatype.joda.JodaModule': src/main/java/de/rwth/idsg/steve/config/SecurityConfiguration.java#L22
Reports import statements that can be removed. They are either unused, duplicated, or the members they import are already implicitly in scope, because they're in java.lang, or the current package. UnnecessaryImport (Priority: 4, Ruleset: Code Style) https://pmd.github.io/pmd-6.49.0/pmd_rules_java_codestyle.html#unnecessaryimport
Unused import 'de.rwth.idsg.steve.ocpp.task.*': src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java#L23
Reports import statements that can be removed. They are either unused, duplicated, or the members they import are already implicitly in scope, because they're in java.lang, or the current package. UnnecessaryImport (Priority: 4, Ruleset: Code Style) https://pmd.github.io/pmd-6.49.0/pmd_rules_java_codestyle.html#unnecessaryimport
checkstyle
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-java@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
license-check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/setup-java@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
license-check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-java@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "PMD Report". Please update your workflow to use v4 of the artifact actions. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Artifacts

Produced during runtime
Name Size
PMD Report Expired
34.2 KB