Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of getObjects() for EntityGroup #117

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Improve performance of getObjects() for EntityGroup #117

merged 1 commit into from
Jul 19, 2022

Commits on Jul 19, 2022

  1. Improve performance of getObjects() for EntityGroup 

    MethodValueCache's getObjects() implementation was fine for a CacheGroup
because everything was already in memory and fast to fetch. However, an
EntityGroup would end up doing a separate query for every requested entity
and this could be quite slow.

This change simply uses the existing functionality of map() to get all
requested entities in a single query so it is faster for an EntityGroup.
Performance for CacheGroups is not impacted significantly.
    Keith R. Gustafson committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    77d7e0c View commit details
    Browse the repository at this point in the history