Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve exception message thrown when not accepting an URL in LinkHandlerFactory#fromUrl(String url, String baseUrl) #638

Merged
merged 1 commit into from
Jun 4, 2021
Merged

Improve exception message thrown when not accepting an URL in LinkHandlerFactory#fromUrl(String url, String baseUrl) #638

merged 1 commit into from
Jun 4, 2021

Conversation

TobiGr
Copy link
Member

@TobiGr TobiGr commented May 28, 2021

It is not a malformed URL, the URL is just not accepted.

@TobiGr
Improve exception message thrown when not accepting an URL in LinkHan…
858e007 
…dlerFactory#fromUrl(String url, String baseUrl)
XiangRongLin
XiangRongLin approved these changes Jun 4, 2021
View reviewed changes
Copy link
Collaborator

@XiangRongLin XiangRongLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the future you can try to shorten the header of the commit messsage. I think it was ~72 characters that will be displayed on GitHub, after which the rest is cut off

@XiangRongLin XiangRongLin merged commit 0ad51e7 into dev Jun 4, 2021
@TobiGr TobiGr deleted the spelling branch June 4, 2021 16:34
This was referenced Jun 5, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiangRongLin XiangRongLin XiangRongLin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TobiGr @XiangRongLin