Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MockOnlyRule to allow skipping specific tests based on downloader #517

Merged
merged 3 commits into from
Mar 20, 2021

Conversation

XiangRongLin
Copy link
Collaborator

@XiangRongLin XiangRongLin commented Jan 16, 2021

-

showcase

@XiangRongLin
Copy link
Collaborator Author

XiangRongLin commented Jan 16, 2021

After thinking about it a bit more i think adding a custom test runner is better.

  • There is an additional overhead of specifiying the customer test runner
  • But it can be easily added on method level, instead of class level

@XiangRongLin
Copy link
Collaborator Author

With rules it's also possible to skip tests on method level instead of class level. Other that that it's the same addtional overhead compared to the developer to add it. But it allows to use other test runner (Mockito).

I adjusted the showcase branch

@XiangRongLin XiangRongLin marked this pull request as ready for review January 30, 2021 09:01
@XiangRongLin XiangRongLin changed the title Add FlakyTestRule to allow skipping specific tests based on downloader Add MockOnlyRule to allow skipping specific tests based on downloader Jan 30, 2021
@XiangRongLin XiangRongLin marked this pull request as draft February 18, 2021 06:40
@Stypox
Copy link
Member

Stypox commented Mar 18, 2021

@XiangRongLin can this be merged? If yes, feel free to do it yourself 😉

@XiangRongLin XiangRongLin merged commit 9009f1e into TeamNewPipe:dev Mar 20, 2021
@XiangRongLin XiangRongLin deleted the flaky_test branch July 10, 2021 08:29
@Stypox Stypox mentioned this pull request Mar 16, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants