-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MockOnlyRule to allow skipping specific tests based on downloader #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After thinking about it a bit more i think adding a custom test runner is better.
|
4 tasks
XiangRongLin
force-pushed
the
flaky_test
branch
from
January 30, 2021 08:48
ea80bb6
to
18bd6d7
Compare
With rules it's also possible to skip tests on method level instead of class level. Other that that it's the same addtional overhead compared to the developer to add it. But it allows to use other test runner (Mockito). I adjusted the showcase branch |
XiangRongLin
changed the title
Add FlakyTestRule to allow skipping specific tests based on downloader
Add MockOnlyRule to allow skipping specific tests based on downloader
Jan 30, 2021
This enforces developers to document why a test is skipped
XiangRongLin
force-pushed
the
flaky_test
branch
from
February 19, 2021 17:55
18bd6d7
to
adf9d7d
Compare
B0pol
reviewed
Feb 20, 2021
XiangRongLin
force-pushed
the
flaky_test
branch
from
February 26, 2021 16:48
9bb7dc6
to
e13e237
Compare
2 tasks
Stypox
approved these changes
Mar 17, 2021
@XiangRongLin can this be merged? If yes, feel free to do it yourself 😉 |
This was referenced Mar 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-
showcase
gradle check -Ddownloader=REAL
and gradle check -Ddownloader=MOCK`