Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-comment out 360p webm #508

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Un-comment out 360p webm #508

merged 1 commit into from
Jan 11, 2021

Conversation

XiangRongLin
Copy link
Collaborator

@opusforlife2
Copy link
Collaborator

Why is the build-and-test action failing?

@XiangRongLin
Copy link
Collaborator Author

@opusforlife2 It's been failing for a very long time because part of the extractor is simply broken or the tests are broken.

See #481 for more information and the linked PR where i try to address it. But haven't really gotten much feedback so i guess it is going to stay like stay for a while

@Redirion
Copy link
Member

@TobiGr this is a trivial change, tested by a few people already. Please merge.

Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember the reason, by that specific codec was commented out on purpose. However, I did not find any bugs with the current player implementation, so I'll merge this PR.

@TobiGr TobiGr merged commit da968cf into TeamNewPipe:dev Jan 11, 2021
@opusforlife2
Copy link
Collaborator

I don't remember the reason, by that specific codec was commented out on purpose.

@TobiGr I think it was before magic man kapodamy implemented merging of video-only + audio-only streams for downloading. You could only download video-only streams, so there needed to be at least one format that would have sound in it, and that was the 360p mp4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants