Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to download items in the queue #9502

Merged
merged 2 commits into from
Dec 31, 2022

Conversation

Jared234
Copy link
Contributor

@Jared234 Jared234 commented Dec 4, 2022

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • i introduced an option to download queue items in their respective long press menu

Before/After Screenshots/Screen Record

Before After
Before After

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@SameenAhnaf SameenAhnaf added feature request Issue is related to a feature in the app downloader Issue is related to the downloader queue Issue is related to queueing labels Dec 5, 2022
Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM

Tapping download on the long-press menu of queue items when the queue is shown inside the player would crash otherwise
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added a commit to use the correct fragment manager.

@Stypox Stypox merged commit 27f6c3b into TeamNewPipe:dev Dec 31, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Stypox Stypox mentioned this pull request Jan 22, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
downloader Issue is related to the downloader feature request Issue is related to a feature in the app queue Issue is related to queueing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Direct download option in long press menu in queue
4 participants