Remove padding from the end of the mini-player

[shivambeohar]

What is it?

• Bugfix (user facing)

Description of the changes in your PR

• removed right-padding of close button LinearLayout.

Before/After Screenshots/Screen Record

Before	After

Fixes the following issue(s)

• fixes There is a gap at bottom-left of miniplayer near close button #8615

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

• I read the contribution guidelines.

[shivambeohar]

Hey, @mhmdanas,
Can you please review the PR, I couldn't able to add the reviewer for this PR.

[Stypox]

@shivambeohar I edited the description to make it more readable, please take a look at my changes

Also see my comment in #8615 (comment)

[Stypox]

This is not the proper way to do it: tapping on R.id.overlay_buttons_layout should not close the player. What I propose is to remove all padding from the overlay_buttons_layout (you can remove the lines) and change widths, heights and paddings of the overlay_play_pause_button and overlay_close_button in order to get the same layout as the current one, but with more clickable space for those buttons.

[Stypox]

I pushed a commit that correctly considers the space to the right of the close button as part of the close button. I also added a content description to the buttons, and made sure the large-land layout is up-to-date with the non-large-land one. I tested on emulators, real phone and real tablet and it works.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information