Remove deprecated method calls in FocusAwareCoordinator. #8670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isira-Seneviratne
force-pushed
the
Update_FocusAwareCoordinator
branch
2 times, most recently
from
d051316
to
73e96e5
Compare
Isira-Seneviratne
force-pushed
the
Update_FocusAwareCoordinator
branch
from
73e96e5
to
f1dab11
Compare
triallax
added
the
codequality
Stypox
approved these changes
Jul 23, 2022
There was a problem hiding this comment.
Seems to work. It was pretty difficult to verify, since the emulator's ui kept crashing after I added cutouts, but it works. Please provide links to documentation when you do deprecated methods refactoring, otherwise I have to look for them myself to verify the code is correct, but I am sure you checked them out, too. Thanks!
| insets.consumeSystemWindowInsets(); | ||
| } | ||
| return insets; | ||
| return consumed ? WindowInsetsCompat.CONSUMED.toWindowInsets() : insets; |
There was a problem hiding this comment.
| * receivers adjust its bounds. So when two listeners are present (like in profile page) | ||
| * the player's controls will not receive insets. This method fixes it | ||
| */ | ||
| @Override | ||
| protected boolean fitSystemWindows(final Rect insets) { | ||
| public WindowInsets onApplyWindowInsets(final WindowInsets windowInsets) { |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
FocusAwareCoordinator.Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence