Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the "(beta)"-tag from services #8637

Merged
merged 2 commits into from
Jul 24, 2022

Conversation

litetex
Copy link
Member

@litetex litetex commented Jul 16, 2022

What is it?

  • Codebase improvement (dev facing)

Description of the changes in your PR

Some time ago we removed the "beta"-tag from all services inside the Readme.
This PR adjusts the app accordingly.

I'm also not sure why there ever was a (beta) flag inside the services as all services are in theory beta (even YT) because we can't guarantee that they are stable as we don't control the remote side.

Before/After Screenshots/Screen Record

grafik

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@litetex litetex added the GUI Issue is related to the graphical user interface label Jul 16, 2022
Copy link
Contributor

@triallax triallax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@triallax triallax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the UI changes do LGTM, but there's a code smell reported by Sonar (the s parameter of enhancePeertubeMenu is not used anymore and should be removed).

@litetex
Copy link
Member Author

litetex commented Jul 24, 2022

@mhmdanas
Done

@sonarcloud
Copy link

sonarcloud bot commented Jul 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@triallax triallax merged commit 51e72d1 into TeamNewPipe:dev Jul 24, 2022
@litetex litetex deleted the remove-beta-service-name branch July 24, 2022 13:22
@Stypox Stypox mentioned this pull request Aug 27, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants