Checkstyle assign on same line #8601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
triallax
added
the
codequality
Stypox
requested changes
Jul 13, 2022
| @@ -18,159 +18,13 @@ | |||
|
|
|||
| package org.schabi.newpipe.util.urlfinder; | |||
There was a problem hiding this comment.
I don't think you can just remove things from this file at random. This file was taken from AOSP and modified, as the licence explains (though a comment would be better), so any change should be documented I guess.
There was a problem hiding this comment.
The changes should already be documented by git (git blame, commit, etc).
Therefore I don't think further action is required as the first line /* THIS FILE WAS MODIFIED, CHANGES ARE DOCUMENTED. */ already describes this.
I added an
//!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
// CHANGED: Removed unused code //
//!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
block so that we are completely on the safe side.
TacoTheDank
reviewed
Jul 14, 2022
litetex
force-pushed
the
checkstyle-assign-on-same-line
branch
from
02f836c
to
fc7fe67
Compare
So that the assign operators are used on the same branch
+ Removed some unused code
litetex
force-pushed
the
checkstyle-assign-on-same-line
branch
from
fc7fe67
to
3ba04f1
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
See #8170 (comment).
After some discussion with @Stypox a while ago (can't find the issue/PR anymore :/ ) where to put the
=on a new line or not we agreed to put it not on the next line.This PR was create to enforce this behavior.
This PR also removes some unused code that was found on the fly.
After the PR is merged the changes should also be applied to https://github.com/TeamNewPipe/NewPipeExtractor
Due diligence