Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified empty_subscription_feed_subtitle to improve discoverability of the subscription import/export menu #8566

Conversation

Poslovitch
Copy link

@Poslovitch Poslovitch commented Jul 1, 2022

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Before/After Screenshots/Screen Record

  • Before:

- After:

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@sonarcloud
Copy link

sonarcloud bot commented Jul 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a few changes:

  1. Somehow "empty_subscription_feed_subtitle" is used inside list_empty_view.xml which is used nearly everywhere and not just in the subscription area:
    grafik
  2. The layout is not correctly aligned
  3. See the comment below

app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
Co-authored-by: litetex <40789489+litetex@users.noreply.github.com>
@foss-enjoyer
Copy link

That's way too long. "Import & export subscriptions from 3-dot menu." would fit better.

@Poslovitch
Copy link
Author

Poslovitch commented Oct 12, 2022

I'm getting back on working on this PR. Please pardon the long delay.
It's currently untested and still WIP.

@Stypox
Copy link
Member

Stypox commented Dec 4, 2022

Since I couldn't push to this PR (you probably forbade pushes to this branch by maintainers), I opened #9501 instead. Thanks anyway!

@Stypox Stypox closed this Dec 4, 2022
@Poslovitch Poslovitch deleted the feat/8504-discoverability-subscription-import-export branch December 11, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discoverability of the subscription import/export menu
4 participants