Add Share menu item to local playlists

[carmebar]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Added ability to share a playlist using a list of video URLs

Before/After Screenshots/Screen Record

• Before:
  
• After:
  

Fixes the following issue(s)

• Fixes Share playlist or export it to text or clipboard #1788

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

• I read the contribution guidelines.

[SameenAhnaf]

#1788 (comment) could have been used instead. YouTube allows anonymous playlists for upto 50 videos.

Example playlist URL: http://www.youtube.com/watch_videos?video_ids=5aTwJEW_Se4,7zplexrqshk,i9ZzrGYEhhw

[carmebar]

@SameenAhnaf I choose a link per video to allow more flexible usage and easier implementation. If there's some interest I might add an option in the settings panel to choose what format to share the playlist. If there are more than 50 videos in the playlist I could generate multiple links.

[SameenAhnaf]

Ok, thanks. I actually need to turn on this toggle in content settings as there's a limit for characters in text messages.

Toggle: Allow Anonymous YouTube Playlist Sharing
Sub-note: This option will only work only if 50 or less YouTube videos are to be shared

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[Stypox]

I rebased and pushed a commit myself, since there were various problems:

• There was no need to use a isSharingPlaylist boolean to prevent the user from tapping the button multiple times in a row. Such a check would be needed if the button modified the playlist, in which case pressing multiple times would lead to possible problems, but in this case if the user wants to share twice (in a row, before waiting for the previous share to be done), let them do whatever they want.
• The list elements (loading, error panel, ...) were used to show loading/errors for the sharing process. This is not a good idea, since those elements have to do with the list itself, not the actions you perform on it, otherwise strange situations would occur. Also, there is no need to show a loading indicator for the share button, it probably only takes a few microseconds to complete.
• A new "Share playlist" string was added, but I think the already-translated "Share" works better and is more standard.
• The share button was being hidden in the three-dot menu, but it is better if it is shown, when there is room.

Thank you anyway @carmebar, and please tell me if these changes look good to you ;-)

[carmebar]

Looks great. Thanks for taking the time to write such informative feedback. Much appreciated.

[nlof]

This seems to generate a list of youtube links. Playing each individual link and adding them one by one to a youtube playlist is very tedious. I didn't find a way to add them all at once to a youtube playlist. Am I missing something?

If not, the 50 links playlist implementation would be more helpful...

[carmebar]

@nlof this feature is intended to share all the videos from a playlist outside NewPipe in a simple list. To import videos into a Youtube playlist you can follow these steps: https://webapps.stackexchange.com/a/106340 (the 'add all' in the dropdown might have been removed...)

[nlof]

@carmebar Thanks for that link. It's pretty cumbersome though, I don't like getting that techy, it's too time consuming and I don't know linux. There was however a google spreadsheet which might work... hopefully :)