Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when rotating device on unsupported channels #8192

Merged
merged 4 commits into from
May 6, 2022

Conversation

GGAutomaton
Copy link
Contributor

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

See #6696 (comment)

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@GGAutomaton
Copy link
Contributor Author

GGAutomaton commented Apr 13, 2022

Reproduction steps:

  1. Open a channel which is not supported by NewPipe, e.g., https://www.youtube.com/channel/UClYV6hHlupm_S_ObS1W-DYw
  2. Rotate the screen

Also test rotation on a normal channel, the behavior is the same as before.

@AudricV AudricV added bug Issue is related to a bug GUI Issue is related to the graphical user interface labels Apr 13, 2022
@Stypox
Copy link
Member

Stypox commented May 2, 2022

Btw, I don't think I am able to test properly. The crash on this channel is actually fixed, but showContentNotSupported should do something: making views visible and showing kaomojis. Could you look into why nothing of that happens? Btw, there is no need to do that in this PR.

@GGAutomaton
Copy link
Contributor Author

GGAutomaton commented May 4, 2022

Mod note: don't quote if you don't need to. Or quote only the necessary parts.

I haven't found the reason yet. I'll try again when I'm free.

@GGAutomaton GGAutomaton requested a review from Stypox May 4, 2022 15:48
@litetex
Copy link
Member

litetex commented May 4, 2022

@Stypox

You have fallen victim to #6870 😉

@sonarcloud
Copy link

sonarcloud bot commented May 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Stypox
Copy link
Member

Stypox commented May 6, 2022

I can confirm it works, then. Thank you! #6870 needs to be solved separately, but at least this crash is fixed.

Btw, you got PR number 8192=2^13, feel honoured by that ;-)

@Stypox Stypox merged commit 5b435c5 into TeamNewPipe:dev May 6, 2022
@GGAutomaton
Copy link
Contributor Author

I can confirm it works, then. Thank you! #6870 needs to be solved separately, but at least this crash is fixed.

Btw, you got PR number 8192=2^13, feel honoured by that ;-)

The software engineering course of our college requires to contribute to the open source community.
I have also learned a lot from this project. Thank you for your warm help :)

@Stypox
Copy link
Member

Stypox commented May 6, 2022

Great :-D

@Stypox Stypox mentioned this pull request Jun 24, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when rotating device on unsupported channels
4 participants