Fix error notification on KitKat #7977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was crashing due to a drawable icon being used; also use NotificationManagerCompat
TobiGr
added
bug
|
Kudos, SonarCloud Quality Gate passed! |
litetex
requested changes
Mar 2, 2022
|
Thank you, as a KitKat NewPipe user I appreciate it! Hope this gets merged and released before support drops. |
|
Ping, so someone merges this approved PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
The app was crashing when trying to display an error notification on KitKat, this PR fixes that by using a non-vector-drawable on API < Lollipop. I also replaced
NotificationManagerwithNotificationManagerCompat, just like in the player'sNotificationUtil.The crash was encountered while testing other thing and is about "Bad notification posted from package ... Couldn't create icon ..."
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence