Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct app language when searching in the settings #7860

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

litetex
Copy link
Member

@litetex litetex commented Feb 11, 2022

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • When you currently search inside the settings (introduced Made preferences searchable #7586) you end up with results that are displayed in the phone's language. This PR fixes this bug by using the app language.

Before/After Screenshots/Screen Record

  • Device language is en - English
  • App language is de - German
Before After
grafik grafik

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@litetex litetex added bug Issue is related to a bug GUI Issue is related to the graphical user interface labels Feb 11, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@TobiGr TobiGr merged commit 5e593f6 into TeamNewPipe:dev Feb 11, 2022
@TobiGr TobiGr mentioned this pull request Feb 11, 2022
1 task
@litetex litetex deleted the fix-settings-search-language branch February 12, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants