Add app icon to fastlane metadata #7672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason F-Droid decided not to grab it from Android metadata anymore
litetex
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
I copied
app/src/main/res/mipmap-xxxhdpi/ic_launcher.pngintoicon.pngin theen-USfastlane metadata, since for some reason F-Droid decided not to grab it from Android metadata anymore and so NewPipe has no icon on the website and on F-Droid clients. I think this is the appropriate solution, since the most recently published F-Droid app hasicon.pngin the fastlane metadata and it seems to be working. There doesn't seem to be any other reference to the app icon in that app's build metadata, so F-Droid should be taking it from fastlane.Note: an alternative to copying would have been to create a symlink, but I don't know if the F-Droid build tool would accept them, so I think a plain old copy paste is ok.
Due diligence