Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small improvements to code quality and readability #7562

Merged
merged 3 commits into from
Dec 23, 2021
Merged

Small improvements to code quality and readability #7562

merged 3 commits into from
Dec 23, 2021

Conversation

TobiGr
Copy link
Member

@TobiGr TobiGr commented Dec 20, 2021 •
edited
Loading

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Make PlayerHolder.bound private
  • Introduce constants for some Strings that indicate no data in Tab class
  • Add annotations to methods and parameters.
  • Replace Jetbrains' @NotNull with Androidx' @NonNull annotatiation.
  • Make class variables static if possible.
  • Use constants for some Strings.
  • Simplify if conditions.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@TobiGr TobiGr added the codequality Improvements to the codebase to improve the code quality label Dec 20, 2021
@TobiGr TobiGr force-pushed the code-quality branch 3 times, most recently from f48e6e6 to 2adaa28 Compare December 20, 2021 23:31
@TobiGr
Make PlayerHolder.bound private
a163d54
@TobiGr
Introduce constants for some Strings that indicate no data in Tab class
d71af9a
@TobiGr
Small improvements to code quality and readability
37b8a93 
Add annotations to methods and parameters.
Replace Jetbrains' @NotNull with Androidx' @nonnull annotatiation.
Make class variables static if possible.
Use constants for some Strings.
Simplify if conditions.
@sonarcloud
Copy link

sonarcloud bot commented Dec 22, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
1.6% 1.6% Duplication

@TobiGr TobiGr merged commit 2158802 into dev Dec 23, 2021
@TobiGr TobiGr deleted the code-quality branch December 23, 2021 22:54
This was referenced Feb 11, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AudricV AudricV AudricV approved these changes

Assignees
No one assigned
Labels
codequality Improvements to the codebase to improve the code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TobiGr @AudricV