Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gradle wrapper Sha256 #7418

Merged
merged 1 commit into from
Nov 21, 2021
Merged

Add gradle wrapper Sha256 #7418

merged 1 commit into from
Nov 21, 2021

Conversation

Redirion
Copy link
Member

@Redirion Redirion commented Nov 18, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

https://docs.gradle.org/current/userguide/gradle_wrapper.html#sec:verification

The Gradle Wrapper allows for verification of the downloaded Gradle distribution via SHA-256 hash sum comparison. This increases security against targeted attacks by preventing a man-in-the-middle attacker from tampering with the downloaded Gradle distribution.

it was removed over 2 years ago e1d2c57

Current Android Studio does not seem to have any issue with it. So it should be added again and kept in sync with future gradle wrapper updates.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@opusforlife2 opusforlife2 merged commit 1de21fb into dev Nov 21, 2021
@opusforlife2 opusforlife2 deleted the add-gradle-wrapper-Sha256 branch November 21, 2021 08:26
@triallax triallax mentioned this pull request Nov 26, 2021
2 tasks
This was referenced Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants