Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent automatic replay after returning from background #7381

Conversation

litetex
Copy link
Member

@litetex litetex commented Nov 8, 2021

See also #7195 (comment)

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Successor to #7195

  • If the video has completed, when the app returns from background, prevent the player from staring playback automatically

Analysis of the problem: #7195 (comment)

Steps to reproduce the bug:

  1. Play a video
  2. Lock the device while the video is still playing
  3. Wait until the video ends
  4. Unlock the device
  5. The video starts playing again automatically

Before/After Screenshots/Screen Record

  • Before:
newpipe_bug.mp4
  • After:
newpipe_litetex_bug.mp4

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@litetex litetex added bug Issue is related to a bug player Issues related to any player (main, popup and background) labels Nov 8, 2021
@litetex litetex force-pushed the prevent-automatic-replay-after-returning-from-background branch from 7d29897 to 010c607 Compare November 15, 2021 18:47
@litetex litetex marked this pull request as draft November 15, 2021 18:51
@litetex litetex marked this pull request as ready for review November 15, 2021 18:57
@XiangRongLin XiangRongLin merged commit bd9dcfb into TeamNewPipe:dev Nov 17, 2021
@litetex litetex deleted the prevent-automatic-replay-after-returning-from-background branch November 17, 2021 17:50
This was referenced Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug player Issues related to any player (main, popup and background)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants