Change player progress bar update from 500 ms to 1 s

[ghost]

Just like in the issue #7062, this doesn't affect UI as it updates every one second anyway, but reduces very heavy android widget progress bar high cpu usage. With every 500 ms there is 6% cpu usage and with 1 s only 4%. However further changes will have to be made to disable updating of player progress bar when screen is off to further reduce power consumption. With this, total power savings would be 20% in mAh consumption in background playback. This pull request does approx 10% longer screen-off playback.

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

Change frequency of player progress bar update to 1s

Fixes the following issue(s)

• Fixes High CPU usage #7062

Due diligence

• I read the contribution guidelines.

[ghost]

Testing results are 0.0395 mAh / s versus 0.046 mAh / s without patch, so therefore with 500 ms the power consumption on Moto G4 with android 7 is 16% higher. Note this is done in controlled way the way that the player is started from scratch. After some time garbage collection usage due to progress bar widget string operations grows 2x but when changing playlist it reduces a bit but not to the minimum as with this test. Hence stopping progress update on screen off would really increase playback time a lot.

[litetex]

Fun fact:
This was originally 1s. However it got changed to 500ms in
4553850#diff-7a10d4f22d171ff412c4fd220a9c6eeffe68ba93c4a88fe9b8088c3017795c85L334
4553850#diff-2ed842dce430debfa98eadea4336fe9e0ed85295c56e8959d361cc88bcedd07bR148

And never got changed back...

[Redirion]

good catch!

[TobiGr]

Do we want to inlcude this into 0.21.10? If yes, we need to change the target branch.

[opusforlife2]

@TobiGr I vote yes.

[Redirion]

can this be done with the "Rebase and merge" option? I didn't use it yet and don't want to break anything.

[TobiGr]

@Redirion It's done via the Edit button next to the PR title.

[ghost]

@TobiGr don't PRs get merged into TeamNewPipe:dev not TeamNewPipe:release/0.21.10?

[TobiGr]

generally: yes
But this case is different. We already started the release process for 0.21.10, i.e. new features and code chages are merged to dev while the release process continues in a separate branch. This is a significant improvement which should be included in the next release and is therefore merged into the release branch. The release branch is later merged back into dev.

[opusforlife2]

However further changes will have to be made to disable updating of player progress bar when screen is off to further reduce power consumption.

@thefalsedev Have you documented this anywhere? If not, please open a new issue with whatever you think is required (or reopen your linked issue if it already contains the relevant info).

Edit: also, do you see the same power consumption stats with the pre-unified version? #4918