Add how to remove tab from main page text

[ktprograms]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Added a message on how to remove an item from the content of main page.

Before/After Screenshots/Screen Record

Before

After

Fixes the following issue(s)

• Fixes add indication as to how "content of main page" is edited #3400

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

• I read the contribution guidelines.

[Stypox]

That text in that place looks odd. I would add a subtitle to the toolbar (this should be easily doable without adding new views, but just with .setSubtitle();) saying "Swipe items to remove them"

[ktprograms]

I've moved it to the subtitle, but it seems if the text is too long it just cuts it instead of wrapping?

[Stypox]

@ktprograms what about "Swipe to remove"?

[ktprograms]

@ktprograms what about "Swipe to remove"?

@Stypox The cropping is only really a problem if the text is too long in different translations.

[Stypox]

The cropping is only really a problem if the text is too long in different translations.

Mmmh, yes... I don't know what we should do. The fragment title would also be cropped in some locales, but we never cared about that as that's just the default android behaviour.

Maybe you could add a centered description text at the top of the activity with appropriate padding above and below, similarly to the "Edit each notification..." text at the top of the action button section in "Notification" settings.

[ktprograms]

The fragment title would also be cropped in some locales

Is there any plan to solve this in future?

[Stypox]

Is there any plan to solve this in future?

I don't think so, that's just the way Android works... But titles are usually small (i.e. single words) even when translated.

[ktprograms]

I don't think so, that's just the way Android works... But titles are usually small (i.e. single words) even when translated.

Ok, in that case I think I'll just follow your suggestion to have the text at the top and centered.

[Stypox]

Ok, in that case I think I'll just follow your suggestion to have the text at the top and centered.

Sorry, I don't get how this is related to "I don't [...] translated.". I was talking generally about the title in the toolbar that you can see in almost every activity and fragment throughout the app.

[ktprograms]

I meant that the current approach works for titles since they're quite short, but for this help text I'll put it below the ActionBar.

[Stypox]

Yes, and make sure the text can wrap

[ktprograms]

@Stypox why does fragment_choose_tabs.xml use RelativeLayout? If there's no problem, I'd prefer to convert it to ConstraintLayout which I'm more familiar with.

Edit: I noticed this comment you made: #5813 (review). Does your opinion on RelativeLayout vs ConstraintLayout still hold?

[Stypox]

If there's no problem, I'd prefer to convert it to ConstraintLayout which I'm more familiar with.

Yes please, I still hate RelativeLayouts, don't worry :-)

[ktprograms]

@Stypox done in e95637f

[opusforlife2]

@ktprograms New screenshot, please?

[ktprograms]

[opusforlife2]

Thanks! That looks great. I was thinking about the centre of the screen, but that would cause the text to be hidden if the user adds more tabs. This position is much better.

[TobiGr]

Thank you!

[Stypox]

Perfect, thank you! :-)

Outdated