Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add sharing of the content name with the "Share" command #6957

Merged
merged 3 commits into from
Aug 27, 2021

Conversation

acti0
Copy link
Contributor

@acti0 acti0 commented Aug 23, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Sharing a content also shares its title as the subject extra intent (Intent.EXTRA_SUBJECT).

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@ktprograms
Copy link
Contributor

@acti0 I think the preferred way is a rebase instead of a merge commit (see https://github.com/TeamNewPipe/NewPipe/wiki/How-to-merge-a-PR)

Copy link
Member

@AudricV AudricV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't concatenate the title and the content shared. Doing this will create issues when sharing crash reports (the string Error report will be always included with crash reports), and some users want only to share the URL of the content.

That's why you should use this instead:

        if (!title.isEmpty()) {
            shareIntent.putExtra(Intent.EXTRA_TITLE, title);
            shareIntent.putExtra(Intent.EXTRA_SUBJECT, title);
        }

The EXTRA_SUBJECT property of intents is supported for example by most of email clients.

@AudricV AudricV changed the title Re-added sharing of video name with "Share" button Re-add sharing of the content name with the "Share" command Aug 27, 2021
Copy link
Member

@AudricV AudricV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to share some contents on several apps, on the current code implementation and on the APK generated with your changes. With these changes, the subject now appears in my notes app and in my mail client!

Thank you for readding something I removed :)

@AudricV AudricV merged commit d908630 into TeamNewPipe:dev Aug 27, 2021
This was referenced Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-add sharing of video name with "Share" button.
3 participants