Fixed shuffle button opacity UI bug

[0x416c6578]

Parameterised shuffle state into initPlayback for potentially passing the shuffle state into the player in the future

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Fixes the shuffle mode button UI bug and parameterizes the shuffle mode in initPlayback (to potentially allow passing the saved shuffle state into the player in the future)

Fixes the following issue(s)

• Fixes Queue shuffle button highlighted when queue is not shuffled #6825

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

• I read the contribution guidelines.

[Stypox]

Are you sure this doesn't reset the queue shuffle mode when switching players?

[Stypox]

@0x416c6578 have you done anything new? Should this be reviewed? Sorry for not noticing earlier, I didn't see the notification

[0x416c6578]

I just realised I assumed it had been fixed by someone else since it wasn't a problem in the app on my phone, but then I remembered I am using builds from my own fork with the above fix lol. The only change I ended up making was adding the line onShuffleModeEnabledChanged(false); to handleIntent.

[Stypox]

Thank you, that's good. Could you verify this in the multiple conditions that initPlayback is called?

Are you sure this doesn't reset the queue shuffle mode when switching players?

Then this can be merged

[litetex]

Reminder ping @0x416c6578

[0x416c6578]

sorry, was a bit snowed down with uni work,
it seems to keep shuffle mode when going to and from background mode, however i think that in the future some sort of shuffle state flag will need to be added to better keep track of the shuffle mode (the starts of which was removed in 5513178).
when I have some time i'll work on a PR to do what was mentioned in #6844 (comment)

[litetex]

@0x416c6578

Ty for the feedback.
Changing the state of the PR to a draft then.
You can change it back once it's ready for review.

[0x416c6578]

for reference the changes in this PR are working, so this could be merged. i'll just open another one with the aforementioned changes when i have some time :/ (unless you just want all the changes in one PR)

[litetex]

Rebased the branch and rewrote the fix so it uses setShuffleButton(binding.shuffleButton, simpleExoPlayer.getShuffleModeEnabled()); instead.
Why?
We just want to fix the UI so no need to call the heavier onShuffleModeEnabledChanged which triggers additional events and un-shuffles the queue.

[litetex]

While testing I found out that the icon in the notification is broken and doesn't update:

Was also affecting the playqueue-activity.

Investigating...

[litetex]

Fixed the problem:
The backup-list which determines if the playqueue is shuffled or not was not created when <= 2 items are in the current playlist. This made caused the notification-toggle to fail.

[litetex]

Rewrote the fix as mentioned and tested it with a few scenarios.
Approved from my side.
If anyone else could test this PR that would be great.

[tsiflimagas]

I'm not sure if by "anyone else" you meant some other dev or any user, but I tested this and seems to be working fine.

Dismissed stale review