Swap seekbar position with player buttons in Queue screen #6824

phigjm · 2021-08-01T23:22:26Z

What is it?

Bugfix (user facing)
Feature (user facing)
Codebase improvement (dev facing)
Meta improvement to the project (dev facing)

Description of the changes in your PR

reorder the Controll elements of the Play queue (putting the Title down)

Before/After Screenshots/Screen Record

Before	After

Fixes the following issue(s)

Fixes Full Screen Minimize Gesture Conflicts with Background Player Track Progress / Seek Bar #6788
Fixes [Feature Request/Android 10 Bug] Move the video controls at the very bottom of the screen up to prevent accidental touches by fullscreen users #2931
Better view of the current playtime when seeking.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

I read the contribution guidelines.

blindm0use · 2021-08-02T10:31:28Z

Great job fixing my issue!
It is best to place timecode popup dialog while seeking either in the middle of the screen or slightly above the seek bar. Otherwise vision gets obstructed by the finger while seeking. Thanks!

phigjm · 2021-08-02T11:46:34Z

Great job fixing my issue!
It is best to place timecode popup dialog while seeking either in the middle of the screen or slightly above the seek bar. Otherwise vision gets obstructed by the finger while seeking. Thanks!

I'll give it a try.

phigjm · 2021-08-02T14:43:23Z

Here you are

SameenAhnaf · 2021-08-03T12:42:02Z

@phigjm Thanks for opening a PR. I don't have a device with the bug. So, rectify me if I am wrong.

But I think, seek bar should be placed in the middle and preview should be shown within the title bar as it used to do. Google Podcasts works this way. Could you please give it a go?

Stypox · 2021-08-04T08:14:34Z

@SameenAhnaf I agree with you, we should follow that ordering. Also, @phigjm try to make it look like as if there is the same spacing between seekbar-title and seekbar-buttons.

phigjm · 2021-08-04T22:01:27Z

This is how it looks now:

at the bottom, there is just enough space to fully represent the play button effects. These buttons seem to only trigger at release. So there should be no problem with the gesture navigation.
I also decided (as you can see) to move the Time above the title as it is transparent and therefore doesn't look that grate over the title.

phigjm · 2021-08-04T22:17:16Z

And here a screenshot from a simulated pixel a3:

app/src/main/res/layout/activity_player_queue_control.xml

Stypox · 2021-08-05T09:31:08Z

The last two screenshots look really good to me. Thank you! I've edited all of your comments to use <img src="" height="300px"/> for screenshots so that they aren't so big.

phigjm · 2021-08-05T09:35:34Z

The last two screenshots look really good to me. Thank you! I've edited all of your comments to use <img src="" height="300px"/> for screenshots so that they aren't so big.

Thank you

from bottom to top: Playback_controls, progress bar, center, (seek display)

Stypox

I rebased and squashed; I un-nested some views (unrelated to your work). Thank you!

litetex · 2021-09-25T08:45:55Z

@Stypox
Is this ready for merging?

opusforlife2 · 2021-10-02T06:33:26Z

@litetex If he's approved it and not asked anyone else to review, then it must mean he considers it ready. Is that right, @Stypox?

reorder the Control Elements of the background player (putting the Title down) TeamNewPipe#6824 Fixes; TeamNewPipe#6788 TeamNewPipe#2931 Co-Authored-By: phigjm <39876427+phigjm@users.noreply.github.com>

reorder the Control Elements of the background player (putting the Title down) TeamNewPipe/NewPipe#6824 Fixes: TeamNewPipe/NewPipe#6788 TeamNewPipe/NewPipe#2931 new icons in background player by avently commit made image view from playQueue visible by avently in commit TeamNewPipe/NewPipe@dd726fa#diff-EFCAA05775EEBAE5D5E7D3DD8FB04196 from TeamNewPipe/NewPipe#4360 Co-Authored-By: Stanislav Dmitrenko <7953703+avently@users.noreply.github.com> Co-Authored-By: wb9688 <46277131+wb9688@users.noreply.github.com> Co-Authored-By: phigjm <39876427+phigjm@users.noreply.github.com>

Reorder the Control Elements of the background player (putting the Title down) TeamNewPipe/NewPipe#6824 Fixes: TeamNewPipe/NewPipe#6788 TeamNewPipe/NewPipe#2931 new icons in background player by avently commit in v0.20.0 made image view from playQueue visible by avently in commit TeamNewPipe/NewPipe@dd726fa#diff-EFCAA05775EEBAE5D5E7D3DD8FB04196 from TeamNewPipe/NewPipe#4360 Co-Authored-By: phigjm <39876427+phigjm@users.noreply.github.com> Co-Authored-By: Stanislav Dmitrenko <7953703+avently@users.noreply.github.com>

reorder the Control Elements of the background player (putting the Title down) TeamNewPipe/NewPipe#6824 Fixes: TeamNewPipe/NewPipe#6788 TeamNewPipe/NewPipe#2931 new icons in background player by avently commit made image view from playQueue visible by avently in commit TeamNewPipe/NewPipe@dd726fa#diff-EFCAA05775EEBAE5D5E7D3DD8FB04196 from TeamNewPipe/NewPipe#4360 Co-Authored-By: Stanislav Dmitrenko <7953703+avently@users.noreply.github.com> Co-Authored-By: wb9688 <46277131+wb9688@users.noreply.github.com> Co-Authored-By: phigjm <39876427+phigjm@users.noreply.github.com>

triallax added the GUI Issue is related to the graphical user interface label Aug 2, 2021

Stypox requested changes Aug 5, 2021

View reviewed changes

app/src/main/res/layout/activity_player_queue_control.xml Outdated Show resolved Hide resolved

phigjm requested a review from Stypox August 9, 2021 11:57

phigjm and others added 2 commits August 9, 2021 20:11

Rearrange the play queue control elements

e6c56ca

from bottom to top: Playback_controls, progress bar, center, (seek display)

Un-nest some text views in play queue activity

4d50a66

Stypox force-pushed the player_queue_control_rearrangement branch from 21037ea to 4d50a66 Compare August 9, 2021 18:12

Stypox approved these changes Aug 9, 2021

View reviewed changes

opusforlife2 changed the title ~~Rearrange the control elements~~ Swap seekbar position with player buttons in Queue screen Oct 2, 2021

opusforlife2 mentioned this pull request Oct 2, 2021

move player controls up on Android 10 #3003

Closed

1 task

TobiGr merged commit 5b31370 into TeamNewPipe:dev Oct 2, 2021

This was referenced Oct 2, 2021

Release/0.21.11 #7192

Merged

Release 0.21.11 #7193

Closed

tsiflimagas mentioned this pull request Nov 2, 2021

Use custom TextViews and EditTexts in all XML resources #7061

Merged

5 tasks

AudricV mentioned this pull request Nov 2, 2021

"Unrevert" changes from pull request 6824 #7348

Merged

2 tasks

ShareASmile mentioned this pull request Jun 16, 2024

Swap seekbar position with player buttons in background player screen ShareASmile/NewPipe-Legacy-Revo#24

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Swap seekbar position with player buttons in Queue screen #6824

Swap seekbar position with player buttons in Queue screen #6824

phigjm commented Aug 1, 2021 •

edited by opusforlife2

Loading

blindm0use commented Aug 2, 2021

phigjm commented Aug 2, 2021

phigjm commented Aug 2, 2021 •

edited by Stypox

Loading

SameenAhnaf commented Aug 3, 2021 •

edited by Stypox

Loading

Stypox commented Aug 4, 2021

phigjm commented Aug 4, 2021 •

edited by Stypox

Loading

phigjm commented Aug 4, 2021 •

edited by Stypox

Loading

Stypox commented Aug 5, 2021

phigjm commented Aug 5, 2021

Stypox left a comment

litetex commented Sep 25, 2021

opusforlife2 commented Oct 2, 2021

Swap seekbar position with player buttons in Queue screen #6824

Swap seekbar position with player buttons in Queue screen #6824

Conversation

phigjm commented Aug 1, 2021 • edited by opusforlife2 Loading

What is it?

Description of the changes in your PR

Before/After Screenshots/Screen Record

Fixes the following issue(s)

APK testing

Due diligence

blindm0use commented Aug 2, 2021

phigjm commented Aug 2, 2021

phigjm commented Aug 2, 2021 • edited by Stypox Loading

SameenAhnaf commented Aug 3, 2021 • edited by Stypox Loading

Stypox commented Aug 4, 2021

phigjm commented Aug 4, 2021 • edited by Stypox Loading

phigjm commented Aug 4, 2021 • edited by Stypox Loading

Stypox commented Aug 5, 2021

phigjm commented Aug 5, 2021

Stypox left a comment

Choose a reason for hiding this comment

litetex commented Sep 25, 2021

opusforlife2 commented Oct 2, 2021

phigjm commented Aug 1, 2021 •

edited by opusforlife2

Loading

phigjm commented Aug 2, 2021 •

edited by Stypox

Loading

SameenAhnaf commented Aug 3, 2021 •

edited by Stypox

Loading

phigjm commented Aug 4, 2021 •

edited by Stypox

Loading

phigjm commented Aug 4, 2021 •

edited by Stypox

Loading