Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate items in queue causing endless buffering #6712

Merged
merged 3 commits into from
Jul 22, 2021
Merged

Fix duplicate items in queue causing endless buffering #6712

merged 3 commits into from
Jul 22, 2021

Commits on Jul 21, 2021

  1. Remove equals() method from PlayQueueItem

    @Stypox
    Stypox committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    4a2bd7b View commit details
    Browse the repository at this point in the history

  2. Use url comparison between queue items when disabling preloading 

    From TeamNewPipe#4562: Disable player stream preloading only if the current stream is going to be replaced for sure (see this). equals() was implemented for PlayQueueItems, so that (only) the url is compared when checking them.
    @Stypox
    Stypox committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    fa8630d View commit details
    Browse the repository at this point in the history

  3. Add tests for play queue items' equals()

    @Stypox
    Stypox committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    736cefe View commit details
    Browse the repository at this point in the history