Use NotificationChannelCompat.

[Isira-Seneviratne]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Use NotificationChannelCompat.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

• I read the contribution guidelines.

[TacoTheDank]

AppCompat 1.2.0 to 1.3.0 is a very important library upgrade, being one of the most used core libraries of NewPipe. I'm of the opinion that this be thoroughly tested before being merged, at least to catch possible new behaviors and bugs before new GitHub issues are created.

AppCompat 1.3.0 changelog: https://developer.android.com/jetpack/androidx/releases/appcompat#version_130_3

Edit: compileSdk should not be bumped here either.

[Redirion]

Thank you! I would like to merge all your recent prs, so also #6634, #6638, #6675, #6685

apart from #6675 all PRs do increase the appcompat version. Could you do that in another PR seperately and rebase your PRs accordingly?

Also do you mind if we condense your PRs in the changelog like "general codequality updates" linking to your PRs?

[Isira-Seneviratne]

Thank you! I would like to merge all your recent prs, so also #6634, #6638, #6675, #6685

apart from #6675 all PRs do increase the appcompat version. Could you do that in another PR seperately and rebase your PRs accordingly?

Also do you mind if the condense your PRs in the changelog like "general codequality updates" linking to your PRs?

Yeah, that's fine.

[Redirion]

AppCompat 1.3.0 changelog: https://developer.android.com/jetpack/androidx/releases/appcompat#version_130_3

I was probablly a bit too quick in merging the appcompat lib update as I wanted to get that our of way to be able to merge these PRs.

The transitive dependencies are not matching. I guess we need to adopt.
androidxLifecycleVersion = '2.2.0' -> 2.3.1
'androidx.core:core-ktx:1.3.2' -> 1.5.0

[TacoTheDank]

The transitive dependencies are not matching. I guess we need to adopt.
androidxLifecycleVersion = '2.2.0' -> 2.3.1
'androidx.core:core-ktx:1.3.2' -> 1.5.0

Would be a good idea, yes 😉

[Stypox]

Thank you! It works, both on API 19 emulated, API 29 real and API 30 emulated