Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipping interception of some gestures #4155

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

avently
Copy link
Contributor

@avently avently commented Aug 17, 2020

What is it?

  • Bug fix (user facing)

Description of the changes in your PR

Prevents interception of a swipe on seekbar by top level parent (BottomSheet).
Was:

Now:

  • no such (non-)issue
  • no another (non-)issue related to tapping and swiping on fullscreen button (see the linked (non-)issue too).

Fixes the following issue(s)

Testing apk

app-release.zip

Agreement

@opusforlife2
Copy link
Collaborator

Puts on fake white beard ~ Something you consider an issue may be a non issue for someone else, and vice versa. Such is life. ~ Takes beard off

@avently
Copy link
Contributor Author

avently commented Aug 18, 2020

@opusforlife2 I noticed that you edited my post. You don't have a right on this, create your own posts and do what you want with them.

@opusforlife2
Copy link
Collaborator

ಥ_ಥ

@opusforlife2 opusforlife2 linked an issue Aug 18, 2020 that may be closed by this pull request
@opusforlife2
Copy link
Collaborator

Fine now?

@avently
Copy link
Contributor Author

avently commented Aug 18, 2020

@opusforlife2 yes, linking the issue is fine

@opusforlife2 opusforlife2 added bug Issue is related to a bug player Issues related to any player (main, popup and background) labels Aug 18, 2020
Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@TobiGr TobiGr merged commit bfdc215 into TeamNewPipe:dev Sep 1, 2020
This was referenced Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug player Issues related to any player (main, popup and background)
Projects
None yet
3 participants