Migrate about activity to Jetpack Compose

[Isira-Seneviratne]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Migrate the about activity to use Jetpack Compose and remove unused layout files.
• Add a ScaffoldWithToolbar composable for future reuse in refactoring.
• Remove the ViewPager2 library as its only use was in the about activity.
• Use AboutLibraries to dynamically display the list of external dependencies of the project.

Before/After Screenshots/Screen Record

• Before:
  
  
  

• After:
  
  
  

Fixes the following issue(s)

• Fixes #

Relies on the following changes

• Compose theme improvements #11539

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

• I read the contribution guidelines.

[opusforlife2]

OMG finally a JC PR where there is a visible change in the UI.

[wb9688]

Dark red text for the tabs isn't quite ideal though, but I suppose the PR is still WIP. Can you please mark WIP PRs as draft next time?

Great work again with regards to doing yet another Jetpack Compose migration.

[wb9688]

Now I looked a bit at the code and I think the list of libraries is definitely outdated, so that should be fixed as well.

[TobiGr]

Regarding outdated libs: #11202 should be implemented once this is merged.

[Isira-Seneviratne]

OMG finally a JC PR where there is a visible change in the UI.

The comments PR has visible changes as well.

[Isira-Seneviratne]

Dark red text for the tabs isn't quite ideal though, but I suppose the PR is still WIP. Can you please mark WIP PRs as draft next time?

Great work again with regards to doing yet another Jetpack Compose migration.

It's mostly completed, it's just that one detail remaining.

Also, we might want to review how the theme should look. This should help: https://material-foundation.github.io/material-theme-builder/

[Jean-BaptisteC]

I have noticed 2 things:

• A scroll bar is present with weird color (in my case it's blue)
• Maybe it's better to have a transparent android app bar?

[Isira-Seneviratne]

I have noticed 2 things:

• A scroll bar is present with weird color (in my case it's blue)

The scrollbar is provided by a third-party library (Compose does not currently support scrollbars).

• Maybe it's better to have a transparent android app bar?

Sounds good.

[sonarcloud]

Quality Gate failed

Failed conditions
9.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

[Isira-Seneviratne]

Regarding outdated libs: #11202 should be implemented once this is merged.

That library includes a composable that automatically displays the external dependencies, so I used that in this PR itself.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud