Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote filename replacement characters to fix crashes when downloading streams with special characters #10489

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Quote filename replacement characters to fix crashes when downloading streams with special characters #10489

merged 1 commit into from
Nov 16, 2023

Conversation

sqproman
Copy link
Contributor

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • fixes crash by quoting replacement char in filename util

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@sqproman sqproman changed the title adds quotation to create filename util replacement char Adds quotation to prevent crash if replacement char is $ or / Oct 12, 2023
@sqproman sqproman changed the title Adds quotation to prevent crash if replacement char is $ or / Adds quotation to prevent downloading from crash if replacement char is $ or / Oct 12, 2023
@TobiGr TobiGr added bug Issue is related to a bug downloader Issue is related to the downloader labels Oct 12, 2023
@TobiGr
Copy link
Member

TobiGr commented Oct 12, 2023

Privacy hint: comitter and PR author do not match.

@sqproman
Copy link
Contributor Author

Privacy hint: comitter and PR author do not match.

Thanks

@sqproman sqproman force-pushed the missing_quotation_replace_char_crash branch from c59641a to 6d0bb02 Compare October 13, 2023 04:28
@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

TobiGr
TobiGr approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AudricV AudricV changed the title Adds quotation to prevent downloading from crash if replacement char is $ or / Quote filename replacement characters to fix crashes when downloading streams with special characters Oct 14, 2023
@Stypox Stypox merged commit 545f9ae into TeamNewPipe:dev Nov 16, 2023
9 of 10 checks passed
@Stypox Stypox mentioned this pull request Nov 16, 2023
Closed
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiGr TobiGr TobiGr approved these changes

Assignees
No one assigned
Labels
bug Issue is related to a bug downloader Issue is related to the downloader
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crashes while trying to download video with title including | or /
3 participants
@sqproman @TobiGr @Stypox