Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update miscellaneous libraries #10234

Merged
merged 1 commit into from
Sep 17, 2023
Merged

Update miscellaneous libraries #10234

merged 1 commit into from
Sep 17, 2023

Conversation

TacoTheDank
Copy link
Member

@TacoTheDank TacoTheDank commented Jul 15, 2023

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@TobiGr TobiGr added the dependency Issues and PRs related to dependencies label Jul 16, 2023
@wb9688
Copy link
Contributor

wb9688 commented Jul 20, 2023

The changelog of ViewPager2 1.1.0-beta02 says:

Fix compatibility issues with newer versions of RecyclerView. Users of this version of ViewPager2 should update to at least RecyclerView 1.3.1-rc01.

We currently have RecyclerView 1.2.1 however. Does this mean we need to upgrade this as well?

@TacoTheDank
Copy link
Member Author

TacoTheDank commented Jul 20, 2023

@wb9688 The corresponding RecyclerView version seems to contradict this by saying only that version needs ViewPager2 1.1.0-beta02. The way it's worded is confusing. I'll remove the update just in case.

@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Sep 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and did not find any regressions. Changelogs look good, too

@TobiGr TobiGr merged commit 0382782 into TeamNewPipe:dev Sep 17, 2023
8 checks passed
@TacoTheDank TacoTheDank deleted the bumpMisc branch September 19, 2023 20:24
This was referenced Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Issues and PRs related to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants