This repository has been archived by the owner on Jul 10, 2024. It is now read-only.
Adds Github Actions workflow to build and store robotjs binaries #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| agent: macos-11 | ||
| arch: x64 | ||
| - platform: macos-arm | ||
| agent: macos-13-large |
There was a problem hiding this comment.
Isn’t this a cross compile? I believe you need xlarge for Apple Silicon https://github.blog/2023-10-02-introducing-the-new-apple-silicon-powered-m1-macos-larger-runner-for-github-actions/
There was a problem hiding this comment.
I copied it from the Around CI config and I tested it it compiles proper binaries for arm64
kjvenalainen
approved these changes
Jan 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up multiple things that were not needed for how we use robotjs, and also uploads the binaries for all supported platforms to github artifacts.
The reason for this is that this way when building the Around app on the CI, we don't need to build any native modules we can just download the prebuilt binaries, which makes building Around faster and simpler.