Skip to content
This repository has been archived by the owner on Jul 10, 2024. It is now read-only.

update prebuild 10 -> 12 #3

Merged
merged 1 commit into from
Oct 17, 2023
Merged

update prebuild 10 -> 12 #3

merged 1 commit into from
Oct 17, 2023

Conversation

nils-ohlmeier
Copy link

Prebuild 10 prevents us from using Node > 16.
This PR enables using Node 20.

kjvenalainen
kjvenalainen approved these changes Oct 17, 2023
View reviewed changes
Copy link

@kjvenalainen kjvenalainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is OK. @gerhardberger do you see any issues?

gerhardberger
gerhardberger approved these changes Oct 17, 2023
View reviewed changes
Copy link

@gerhardberger gerhardberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it should be good

@nils-ohlmeier nils-ohlmeier merged commit 51b6459 into master Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gerhardberger gerhardberger gerhardberger approved these changes

@kjvenalainen kjvenalainen kjvenalainen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nils-ohlmeier @gerhardberger @kjvenalainen