Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix implementation of optional<T&>::emplace() #34

Merged
merged 3 commits into from
Jul 8, 2019
Merged

Fix implementation of optional<T&>::emplace() #34

merged 3 commits into from
Jul 8, 2019

Conversation

denizevrenci
Copy link
Contributor

Fixes #33

@TartanLlama
Copy link
Owner

Thanks! Will merge when CI goes green.

@denizevrenci
Copy link
Contributor Author

Fixed the noexcept placement at the originating commit.

@TartanLlama TartanLlama merged commit 83a0b49 into TartanLlama:master Jul 8, 2019
@denizevrenci denizevrenci deleted the fix_emplace_on_ref branch July 8, 2019 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tl::optional<T&>::emplace() is implemented incorrectly
2 participants
@denizevrenci @TartanLlama