Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router-valibot-adapter): upgrade valibot to v1 #2470

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

fabian-hiller
Copy link
Contributor

I've upgraded the TanStack Router Valibot adapter to v1. We've changed the type signature, so this change is necessary. All other changes in our v1 beta version are only internal.

I recommend marking the types property of the SearchValidatorAdapter interface as optional, as there is no need to actually include it at runtime.


An union of schema library authors (Zod, Valibot, ArkType, ...) collaborating on a standard interface for schema libraries called Standard Schema. This simplifies implementation and prevents vendor lock-in. So far Valibot v1 supports this spec and Zod will follow soon. In the long run, the explicit implementation of a Valibot and Zod adapter may no longer be necessary.

Copy link

nx-cloud bot commented Oct 4, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fcd2894. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx affected --targets=test:eslint,test:unit,test:e2e,test:types,test:build,build --parallel=3

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Oct 4, 2024

Open in Stackblitz

More templates

@tanstack/create-router

pnpm add https://pkg.pr.new/@tanstack/create-router@2470

@tanstack/eslint-plugin-router

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-router@2470

@tanstack/history

pnpm add https://pkg.pr.new/@tanstack/history@2470

@tanstack/react-cross-context

pnpm add https://pkg.pr.new/@tanstack/react-cross-context@2470

@tanstack/react-router

pnpm add https://pkg.pr.new/@tanstack/react-router@2470

@tanstack/react-router-with-query

pnpm add https://pkg.pr.new/@tanstack/react-router-with-query@2470

@tanstack/router-arktype-adapter

pnpm add https://pkg.pr.new/@tanstack/router-arktype-adapter@2470

@tanstack/router-cli

pnpm add https://pkg.pr.new/@tanstack/router-cli@2470

@tanstack/router-devtools

pnpm add https://pkg.pr.new/@tanstack/router-devtools@2470

@tanstack/router-generator

pnpm add https://pkg.pr.new/@tanstack/router-generator@2470

@tanstack/router-plugin

pnpm add https://pkg.pr.new/@tanstack/router-plugin@2470

@tanstack/router-valibot-adapter

pnpm add https://pkg.pr.new/@tanstack/router-valibot-adapter@2470

@tanstack/router-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/router-vite-plugin@2470

@tanstack/router-zod-adapter

pnpm add https://pkg.pr.new/@tanstack/router-zod-adapter@2470

@tanstack/start

pnpm add https://pkg.pr.new/@tanstack/start@2470

@tanstack/virtual-file-routes

pnpm add https://pkg.pr.new/@tanstack/virtual-file-routes@2470

@tanstack/start-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/start-vite-plugin@2470

commit: fcd2894

@SeanCassiere
Copy link
Member

The unrelated start-basic-auth e2e test looks to be flaky here. Since it is not part of this change, I'm pushing this through.

@fabian-hiller thanks for the heads up on Standard Schema. It's definitely something worth keeping an eye.

@SeanCassiere SeanCassiere changed the title feat: upgrade valibot adapter to v1 feat(router-valibot-adapter): upgrade valibot to v1 Oct 4, 2024
@SeanCassiere SeanCassiere merged commit c850088 into TanStack:main Oct 4, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants