-
-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(router-valibot-adapter): upgrade valibot to v1 #2470
feat(router-valibot-adapter): upgrade valibot to v1 #2470
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit fcd2894. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
Sent with 💌 from NxCloud. |
The unrelated start-basic-auth e2e test looks to be flaky here. Since it is not part of this change, I'm pushing this through. @fabian-hiller thanks for the heads up on Standard Schema. It's definitely something worth keeping an eye. |
I've upgraded the TanStack Router Valibot adapter to v1. We've changed the type signature, so this change is necessary. All other changes in our v1 beta version are only internal.
An union of schema library authors (Zod, Valibot, ArkType, ...) collaborating on a standard interface for schema libraries called Standard Schema. This simplifies implementation and prevents vendor lock-in. So far Valibot v1 supports this spec and Zod will follow soon. In the long run, the explicit implementation of a Valibot and Zod adapter may no longer be necessary.