-
-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow to exclude routes from SSR #2463
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit be843c4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
f5d6225
to
710cb08
Compare
31a64c3
to
4b775c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the usage for this looks to be setting ssr
to false
on the Route.options
, should we have a defaultSsr
flag on the RouterOptions
as well?
So that'd allow both opting out certain routes from SSR as well as the choice of being able to opt-in for SSR on certain routes.
Or conversely, should this maybe be something named like renderMode
? where maybe in the future RSC
would be slotted in. - "csr" | "ssr" | "rsc"
the case against a default value is that we don't have access to the router instance here. so I would not add this right now |
No description provided.