Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to exclude routes from SSR #2463

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Conversation

schiller-manuel
Copy link
Contributor

No description provided.

Copy link

nx-cloud bot commented Oct 3, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit be843c4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Oct 3, 2024

Open in Stackblitz

More templates

@tanstack/create-router

pnpm add https://pkg.pr.new/@tanstack/create-router@2463

@tanstack/eslint-plugin-router

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-router@2463

@tanstack/history

pnpm add https://pkg.pr.new/@tanstack/history@2463

@tanstack/react-cross-context

pnpm add https://pkg.pr.new/@tanstack/react-cross-context@2463

@tanstack/react-router

pnpm add https://pkg.pr.new/@tanstack/react-router@2463

@tanstack/react-router-with-query

pnpm add https://pkg.pr.new/@tanstack/react-router-with-query@2463

@tanstack/router-arktype-adapter

pnpm add https://pkg.pr.new/@tanstack/router-arktype-adapter@2463

@tanstack/router-cli

pnpm add https://pkg.pr.new/@tanstack/router-cli@2463

@tanstack/router-devtools

pnpm add https://pkg.pr.new/@tanstack/router-devtools@2463

@tanstack/router-generator

pnpm add https://pkg.pr.new/@tanstack/router-generator@2463

@tanstack/router-plugin

pnpm add https://pkg.pr.new/@tanstack/router-plugin@2463

@tanstack/router-valibot-adapter

pnpm add https://pkg.pr.new/@tanstack/router-valibot-adapter@2463

@tanstack/router-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/router-vite-plugin@2463

@tanstack/router-zod-adapter

pnpm add https://pkg.pr.new/@tanstack/router-zod-adapter@2463

@tanstack/start-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/start-vite-plugin@2463

@tanstack/start

pnpm add https://pkg.pr.new/@tanstack/start@2463

@tanstack/virtual-file-routes

pnpm add https://pkg.pr.new/@tanstack/virtual-file-routes@2463

commit: be843c4

@schiller-manuel schiller-manuel force-pushed the exclude-routes-from-ssr branch 2 times, most recently from f5d6225 to 710cb08 Compare October 3, 2024 22:48
Copy link
Member

@SeanCassiere SeanCassiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the usage for this looks to be setting ssr to false on the Route.options, should we have a defaultSsr flag on the RouterOptions as well?

So that'd allow both opting out certain routes from SSR as well as the choice of being able to opt-in for SSR on certain routes.

Or conversely, should this maybe be something named like renderMode? where maybe in the future RSC would be slotted in. - "csr" | "ssr" | "rsc"

@schiller-manuel
Copy link
Contributor Author

the case against a default value is that we don't have access to the router instance here. so I would not add this right now

@schiller-manuel schiller-manuel merged commit da9b824 into main Oct 4, 2024
5 checks passed
@schiller-manuel schiller-manuel deleted the exclude-routes-from-ssr branch October 4, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants