-
-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(react-router): remove root search schema type and unused type parameters from route options #1729
Conversation
chorobin
commented
Jun 9, 2024
- remove root search schema as it doesn't seem to be needed
- remove unused type parameters for route options
- added tests to cover index routes and root search schema
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7595d66. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
Reduces instantiations a bit because we don't need to exclude/omit
After
|
Don't merge just yet. Just want to double check everything |
Just want to confirm the |
From what I understand from conversations with @schiller-manuel the users don't use this type unlike |