fix(react-router): take from into account when navigating with params or layouts
#1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckout - routesByPath doesn't include branches, they are deduped with index routes therefor I am using flatRoutes - preload redirects should not include from automatically as it should be explicit - declarative route masking should be pass from because from for route masking does not assert a location
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a982e76. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
chorobin
changed the title
from into acount for routes with params and layoutsfrom into account when navigating with params or layouts
SeanCassiere
reviewed
Jun 9, 2024
packages/react-router/src/router.ts
Outdated
| @@ -1773,8 +1786,7 @@ export class Router< | |||
| preload: !!preload, | |||
| context: parentContext, | |||
| location, | |||
| navigate: (opts: any) => | |||
| this.navigate({ ...opts, from: match.pathname }), | |||
| navigate: (opts: any) => this.navigate({ ...opts }), | |||
There was a problem hiding this comment.
Could avoid the spread here yea?
navigate: (opts: any) => this.navigate(opts as any)
SeanCassiere
changed the title
from into account when navigating with params or layoutsfrom into account when navigating with params or layouts
…ion for preloading and beforeLoad
This was referenced Jul 2, 2024
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fromredirect preloads. Users should specify this manuallyfromin declarative route masks when building the location