Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-plugin-query): update deprecated getSourceCode() method #8117

Merged
merged 3 commits into from
Oct 4, 2024
Merged

fix(eslint-plugin-query): update deprecated getSourceCode() method #8117

merged 3 commits into from
Oct 4, 2024
+4 −1

Conversation

saul-atomrigs
Copy link
Contributor

Captura de pantalla 2024-10-02 a las 12 03 04 a  m
https://eslint.org/docs/latest/extend/custom-rules#accessing-the-source-code

getSourceCode() has been deprecated in favor of sourceCode. This PR introduces the latter, while also keeping the deprecated one as fallback.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Oct 1, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a22eff6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 1, 2024 •
edited
Loading

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8117

@tanstack/angular-query-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@8117

@tanstack/eslint-plugin-query

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@8117

@tanstack/query-async-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@8117

@tanstack/query-broadcast-client-experimental

pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8117

@tanstack/query-core

pnpm add https://pkg.pr.new/@tanstack/query-core@8117

@tanstack/query-devtools

pnpm add https://pkg.pr.new/@tanstack/query-devtools@8117

@tanstack/query-persist-client-core

pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@8117

@tanstack/query-sync-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@8117

@tanstack/react-query

pnpm add https://pkg.pr.new/@tanstack/react-query@8117

@tanstack/react-query-devtools

pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@8117

@tanstack/react-query-next-experimental

pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@8117

@tanstack/react-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@8117

@tanstack/solid-query

pnpm add https://pkg.pr.new/@tanstack/solid-query@8117

@tanstack/solid-query-devtools

pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@8117

@tanstack/solid-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@8117

@tanstack/svelte-query

pnpm add https://pkg.pr.new/@tanstack/svelte-query@8117

@tanstack/svelte-query-devtools

pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@8117

@tanstack/svelte-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@8117

@tanstack/vue-query

pnpm add https://pkg.pr.new/@tanstack/vue-query@8117

@tanstack/vue-query-devtools

pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@8117

commit: a22eff6

@TkDodo TkDodo requested a review from Newbie012 October 1, 2024 15:27
@TkDodo
Copy link
Collaborator

TkDodo commented Oct 1, 2024

you need to disable the linter for that fallback:

/home/workflows/workspace/packages/eslint-plugin-query/src/rules/stable-query-client/stable-query-client.rule.ts
  72:32  error  Unnecessary conditional, expected left-hand side of `??` operator to be possibly null or undefined  @typescript-eslint/no-unnecessary-condition

@codecov Codecov
Copy link

codecov bot commented Oct 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.82%. Comparing base (05924f4) to head (a22eff6).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #8117       +/-   ##
=========================================
+ Coverage      0   87.82%   +87.82%     
=========================================
  Files         0       15       +15     
  Lines         0      493      +493     
  Branches      0      183      +183     
=========================================
+ Hits          0      433      +433     
- Misses        0       46       +46     
- Partials      0       14       +14
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query 87.82% <100.00%> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@saul-atomrigs
Copy link
Contributor Author

Thanks for the reminder, I've just added the eslint-disable

Newbie012
Newbie012 approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@Newbie012 Newbie012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TkDodo TkDodo merged commit bb8278d into TanStack:main Oct 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Newbie012 Newbie012 Newbie012 approved these changes

Assignees
No one assigned
Labels
package: eslint-plugin-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saul-atomrigs @TkDodo @Newbie012