-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(angular-query): support required input signal on injectMutation #7016
feat(angular-query): support required input signal on injectMutation #7016
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 145bb9f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 145bb9f:
|
dd9dea2
to
a8ee8fd
Compare
302aee0
to
8012b4f
Compare
9449e53
to
8bc0d9a
Compare
Nice! Thank you for the additional tests too. |
This pr add required input signal support for
injectMutation
andinjectMutationState
.Like
injectQuery
does, we should support required input signals also forinjectMutation
andinjectMutationState
. The use may be related to some specific mutations that can have asmutationKey
the value of a required input signal. Done that, we may want to get the state of the mutations viainjectMutationState
, which could have as "filter" that value passed as inputI'm adding some new tests via TestBed in both injectMutation/injectQuery in order to be sure that nothings break if we find another solution for the lazy initialization.
I'm also introducing some utils in order to set required signal input via testBed, which seems currently not "officially" supported. I found a related discussion but vitest seems not supporting that yet, so I couldn't use testing-library/angular.
@arnoud-dv