[TASK] Add more unit tests for class TaskManager #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabbelasichon
force-pushed
the
task/add-more-unit-tests-task-manager
branch
from
2d1a319
to
12a2022
Compare
- Create class TaskFactory. The new class is responsible for the real creation of the task. First step to depedency injection container
sabbelasichon
force-pushed
the
task/add-more-unit-tests-task-manager
branch
from
12a2022
to
cfb6f18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
The TaskManager is responsible for the execution and creation of the task
What is the new behavior (if this is a feature change)?
Separate the creation and execution of the task.