Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Beautify path concatenation #338

Merged
merged 5 commits into from
Feb 21, 2020
Merged

[TASK] Beautify path concatenation #338

merged 5 commits into from
Feb 21, 2020

Conversation

simonschaufi
Copy link
Collaborator

@simonschaufi simonschaufi commented Feb 21, 2020 •
edited
Loading

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Task

  • What is the current behavior? (You can also link to an open issue here)

Not the complete path is processed by escapeshellarg()

  • What is the new behavior (if this is a feature change)?

streamline path concatenation. Sometimes \TYPO3\Flow\Utility\Files::concatenatePaths is used, sometimes we just put them together

Resolve #178

@simonschaufi simonschaufi added this to the 3.0.0 stable release milestone Feb 21, 2020
@simonschaufi simonschaufi changed the title [TASK] Beautify path concatenation (#178) [TASK] Beautify path concatenation Feb 21, 2020
@simonschaufi simonschaufi merged commit 8b25952 into master Feb 21, 2020
@simonschaufi simonschaufi deleted the issue-178 branch February 21, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabbelasichon sabbelasichon sabbelasichon approved these changes

@t3easy t3easy Awaiting requested review from t3easy

Assignees
No one assigned
Labels
beautification
Projects
None yet
Milestone
3.0 release
Development

Successfully merging this pull request may close these issues.

[TASK] Beautify path concatenation
2 participants
@simonschaufi @sabbelasichon