Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sourcemaps #9371

Merged
merged 1 commit into from
May 2, 2018
Merged

Fix sourcemaps #9371

merged 1 commit into from
May 2, 2018

Conversation

teohhanhui
Copy link
Contributor

@teohhanhui teohhanhui commented Apr 26, 2018

Q A
Branch? 1.0
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets N/A
License MIT

We should be fine for Node.js compatibility, since yarn doesn't support node < v4 anyway. And for...of with arrays has been supported since node v4: https://node.green/#ES2015-syntax-for--of-loops-with-arrays

@teohhanhui
Copy link
Contributor Author

teohhanhui commented Apr 27, 2018

Note that this does not completely fix the problem with sourcemaps, because all of the source files have their directory structure flattened. It could probably only be solved by passing the base option to gulp.src, which means we'll have to split up the calls based on the base directory.

Update: Fixed!

@Zales0123 Zales0123 added the Potential Bug Potential bugs or bugfixes, that needs to be reproduced. label Apr 27, 2018
@teohhanhui
Copy link
Contributor Author

And the problem with the directory structure is fixed! 😄

@pamil pamil merged commit b2dd99f into Sylius:1.0 May 2, 2018
@pamil
Copy link
Contributor

pamil commented May 2, 2018

Niice, thank you a lot, Teoh! 🎉

@teohhanhui teohhanhui deleted the fix/sourcemaps branch May 2, 2018 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Potential Bug Potential bugs or bugfixes, that needs to be reproduced.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants