Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: update task status #397

Merged
merged 4 commits into from
Feb 15, 2024
Merged

feat!: update task status #397

merged 4 commits into from
Feb 15, 2024

Conversation

SdgJlbl
Copy link
Contributor

@SdgJlbl SdgJlbl commented Feb 13, 2024 •
edited by guilhem-barthes
Loading

Companion PRs

Part of FL-1397

Please check if the PR fulfills these requirements

  • If necessary, the changelog has been updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • The commit message follows the conventional commit specification
  • For any breaking changes, companion PRs have been opened on the following repositories:

@SdgJlbl SdgJlbl requested a review from a team as a code owner February 13, 2024 16:03
@SdgJlbl SdgJlbl changed the title feat: update task status feat!: update task status Feb 13, 2024
@SdgJlbl SdgJlbl force-pushed the geat/update-task-status branch 2 times, most recently from 42e9cdb to e21fbf5 Compare February 13, 2024 16:34
@guilhem-barthes
Copy link
Contributor

/e2e --refs substra-backend=feat/add-new-compute-tasks-status-linked-to-function-status,orchestrator=feat/add-new-compute-tasks-status-linked-to-function-status --tests=sdk,mnist,frontend,camelyon

@Owlfred
Copy link

Owlfred commented Feb 13, 2024 •
edited
Loading

End to end tests: ⚙️ RUNNING

It'll just take a minute.

guilhem-barthes
guilhem-barthes previously requested changes Feb 13, 2024
View reviewed changes
substra/sdk/models.py Show resolved Hide resolved
@linear Linear
Copy link

linear bot commented Feb 13, 2024

FL-1397 Add new statuses on compute task

@guilhem-barthes
Copy link
Contributor

/e2e --refs substra-backend=feat/add-new-compute-tasks-status-linked-to-function-status,orchestrator=feat/add-new-compute-tasks-status-linked-to-function-status --tests=sdk,mnist,frontend,camelyon

@Owlfred
Copy link

Owlfred commented Feb 14, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

That's a shame.

@guilhem-barthes
Copy link
Contributor

/e2e --refs substra-backend=feat/add-new-compute-tasks-status-linked-to-function-status,orchestrator=feat/add-new-compute-tasks-status-linked-to-function-status --tests=sdk,mnist,camelyon

@Owlfred
Copy link

Owlfred commented Feb 14, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

“Boy, that escalated quickly.” ― Ron Burgundy, Anchorman: The Legend of Ron Burgundy

@SdgJlbl
feat!: update task status
64d40e3 
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
@guilhem-barthes
Copy link
Contributor

/e2e --refs substra-backend=feat/add-new-compute-tasks-status-linked-to-function-status,orchestrator=feat/add-new-compute-tasks-status-linked-to-function-status --tests=sdk,mnist,camelyon

@Owlfred
Copy link

Owlfred commented Feb 15, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Better luck next time!

@guilhem-barthes
feat!: rename x_count fields to reflect backend changes
360ae6a 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes
Copy link
Contributor

/e2e --refs substra-backend=feat/add-new-compute-tasks-status-linked-to-function-status,orchestrator=feat/add-new-compute-tasks-status-linked-to-function-status --tests=sdk,mnist,camelyon

@Owlfred
Copy link

Owlfred commented Feb 15, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

“You shall not pass!” ― Gandalf, The Lord of the Rings, The Fellowship of the Ring

This was referenced Feb 15, 2024
Merged
Merged
@guilhem-barthes
Copy link
Contributor

/e2e --refs substra-backend=feat/add-new-compute-tasks-status-linked-to-function-status,orchestrator=feat/add-new-compute-tasks-status-linked-to-function-status,substra-tests=feat/add-new-compute-tasks-status-linked-to-function-status --tests=sdk,mnist,camelyon

@Owlfred
Copy link

Owlfred commented Feb 15, 2024 •
edited
Loading

End to end tests: ✔️ SUCCESS

@guilhem-barthes guilhem-barthes mentioned this pull request Feb 15, 2024
Merged
@guilhem-barthes
fix: replace waiting_for_builder_slot by `waiting_for_executor_slot…
df34f2b 
…` in local worker

Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
This was referenced Feb 15, 2024
Merged
Merged
@guilhem-barthes
Copy link
Contributor

/e2e --refs substra-backend=feat/add-new-compute-tasks-status-linked-to-function-status,orchestrator=feat/add-new-compute-tasks-status-linked-to-function-status,substra-tests=feat/add-new-compute-tasks-status-linked-to-function-status --tests=sdk,mnist,camelyon

@Owlfred
Copy link

Owlfred commented Feb 15, 2024 •
edited
Loading

End to end tests: ✔️ SUCCESS

“To infinity and beyond!” ― Buzz Lightyear, Toy Story

@guilhem-barthes
chore: run make doc
f474c23 
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
ThibaultFy
ThibaultFy approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@ThibaultFy ThibaultFy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks :)

guilhem-barthes added a commit to Substra/orchestrator that referenced this pull request Feb 15, 2024
@guilhem-barthes
feat!: add new compute tasks status linked to function status (#366)
b71e4ee 
## Companion PR

- Substra/substra-backend#823
- Substra/substra-tests#319
- Substra/substra#397
- Substra/substra-frontend#297
- Substra/substra-documentation#390

## Description

<!-- Please reference issue if any. -->

<!-- Please include a summary of your changes. -->

Fixes of FL-1397

## How has this been tested?

<!-- Please describe the tests that you ran to verify your changes.  -->

## Checklist

- [x] [changelog](../CHANGELOG.md) was updated with notable changes
- [ ] documentation was updated

---------

Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
@guilhem-barthes guilhem-barthes merged commit d67381c into main Feb 15, 2024
6 checks passed
@guilhem-barthes guilhem-barthes deleted the geat/update-task-status branch February 15, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guilhem-barthes guilhem-barthes guilhem-barthes left review comments

@ThibaultFy ThibaultFy ThibaultFy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SdgJlbl @guilhem-barthes @Owlfred @ThibaultFy