Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor the local timezone, fix for #369, stop time travel! #735

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

agokhale
Copy link

Since there is no convention for timezones in zips, it's incorrect to assume they are utc. This leads to astonishing behaviour where files are unpacked with different timestamps than they were packed with. (and differs form the command line zip)
The change strips out the explicit UTC calls and relies on the environments' locale.
A test case is included that uses posix style TZ to demonstrate the bug and the fix.

@cyfung1031
Copy link

@Stuk

@agokhale
Copy link
Author

agokhale commented Oct 2, 2023

I'll clean up this for merging ( it's got some old timey conflict weeds ) . .. If there's interest from @Stuk

@agokhale
Copy link
Author

agokhale commented Oct 2, 2023

nevermind the conflict is trivial and can be binned with -X theirs.

Copy link

@khalednigrou khalednigrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UTC time gives me a past time in UTC+ areas
so i suppose we need to get local time back

@agokhale
Copy link
Author

@khalednigrou @Stuk - is there something I need to do to land this?

@kalegd
Copy link

kalegd commented Apr 30, 2024

Just wanted to share interest in this change and +1 this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants